perf: 接入蓝鲸监控APM调用链追踪 #1161 #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jsonwan
commented
Sep 14, 2022
jsonwan
commented
- 使用纯SDK实现trace追踪，去除javaagent；
- 通过Spring Bean创建线程池，实现子线程trace数据传递；
- 自定义Otel SpanExporter配置，支持通过配置项开关trace上报；
- 支持配置trace采样比率；
- BizCmdbClient部分代码重构。
线程池创建使用Spring Bean
BizCmdbClient线程池创建使用Spring Bean
各处线程池创建使用Spring Bean
去除javaagent相关代码
自定义Otel SpanExporter配置
增加trace上报相关参数配置
QueryAgentStatusClient自动装配设为非强依赖
FlowController自动装配设为非强依赖
FlowController自动装配设为非强依赖
支持设置trace采样比率
支持设置trace采样比率
抽取公共common-otel模块，file-worker支持trace上报
移除javaagent
wangyu096
requested changes
Sep 15, 2022
| private void initSpanAndAddRequestId() { | ||
| Span currentSpan = tracer.currentSpan(); | ||
| if (currentSpan == null) { | ||
| currentSpan = tracer.nextSpan().start(); | ||
| } | ||
| spanInScope = tracer.withSpan(currentSpan); | ||
| log.debug("currentSpan={}", currentSpan); | ||
| log.debug("MDC={}", getMDCContext()); |
There was a problem hiding this comment.
- 这里的debug是否有必要
- 如果有必要的话，那么要使用isDebugEnabled判断，因为后面的参数getMDCContext()的调用会克隆一个新的HashMap出来，增加资源消耗
public Map<String, String> getCopyOfContextMap() {
Map<String, String> hashMap = (Map)this.copyOnThreadLocal.get();
return hashMap == null ? null : new HashMap(hashMap);
}
|
|
||
| @Autowired | ||
| public ScriptCheckServiceImpl(DangerousRuleCache dangerousRuleCache) { | ||
| public ScriptCheckServiceImpl(DangerousRuleCache dangerousRuleCache, ExecutorService dangerousRuleCheckExecutor) { |
There was a problem hiding this comment.
这种ExecutorService类型存在多种的，需要加上@qualifier明确指定会比较好一些。排查下其他地方是否存在类似问题
wangyu096
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.